1. TDR Internal Review Chapter 5 Anders J Johansson

2. Overview The introduction divides up the Control System in 5 parts (figure 5.1) : – Control System Core – Control Box – HMI – BLED – Development environment This structure is not used in the text.

4. Overview Sections in the TDR – Introduction5.1 – Control System Core 5.2, 5.3, 5.4, 5.7 – Control Box 5.5 – HMI 5.10, 5.11, 5.12, 5.13, 5.14 – BLED 5.8 – Development environment5.9, 5.15

5. Overview Pagecounts – Introduction11 pages – Control System Core 25 pages – Control Box 3 pages – HMI /Interfaces5 pages /6 pages – BLED 14 pages – Development environment7 pages

6. General Comments Chapter is in a draft stage: – Figures are temporary, generally not reviewed – Tables often lacks content, not reviewed – Some parts are missing, or empty.

7. 5.1 Overview Nice introduction to the control system List on page 5 mixes levels: operating systems and hardware choices. Mixes technical and administrative desctriptions. ”TSS is the responsability of the target division.” ”Networks” list does not mention PPS?

8. 5.2 Timing and Synchronization Detailed account of the timing system. Nice section, but the detail level over the section varies. Details prototyping to a level missing in rest of chapter.

9. 5.3 MPS Defines MPS as ”protect the machine equipment from damage due to beam losses and malfunctioning equipment”. Starts with a nice introduction to design of safety systems. Picture show MPS as part of timing system, which goes against definition in text.

10. 5.4 PPS Defines PPS as protection agains exposure to radiation, electrical shock and other dangers. Short in comparison to MPS.

11. 5.5 Control Box Describes the highlevel implementation of the control box. Prototyping part lacks details compared to timing section.

12. 5.6 Equipment Catalogue More of an organisatoral matter, than design Short, uses a lot of acronyms. Remove, or integrate into chapter 5.5 Control Box.

13. 5.7 Control Systems Services ”Software libraries, servers and standardize interfaces... in the CS Core.” Describes Control Systems Permissions, archiving, logging, Post Mortem Analysis, Save, Alarms, Name Services Discusses alarms, but not their relation to MPS/PPS/TSS

14. 5.8 BLED Central management of data for development, commissioning, operation and maintenance. The acronym is never explained? No discussion on decomissioning. Very detailed, names version numbers of Java and MySQL. Should be shortened. Some parts, e.g. 5.8.4, is organisatorial

15. 5.9 Development Environment ”Composed of services that ensure a simple and consistent software design and development workflow...” Describes software workflow, could be argued to be organisatorial, but should be kept as it descibes the architecture, not the procedure. Section 5.9.5 is empty, remove as it is organisatorial in intended content.

16. 5.10 HMI and user experience Will the user profiles be used in the design as targets, or as classification of actual users and their privelegies? 5.10.4 ”Control room layout” is oddly placed in a chapter only concerning itself with logical signals and computers. If kept, it should be expanded. Unfinished, lots of empty sections. Scope of section needs to be better defined. To detailed in parts: ”Charts should feature colour.”

17. 5.11 Instruments and sample environment control Rename section 5.11.2 ”Interface to Neutron Scattering Instruments” Is a sketch of the interface between Control System and Neutron Scattering Instruments. Figure 5.24 does not match figure 2.45. Inconsistent description of data archiving architecture vs. Chapter 2?

18. 5.12 Target Control Describes a Target Control System. Is this a subsection of the CS, or a separate part? Sections 5.12.2 misses part of the text? The relationsship to the TSS should be more defined, and placed together with MPS and PPS

19. 5.13 Accelerator Control Draft version. Only covers Beam Instrumentation. Describes organisatorial/operations.

20. 5.14 Infrastructure control Move MPS matters to MPS chapter, as it will have the same requirements for speed as the rest of the MPS

21. 5.15 Online and offline beam modelling and simulation Not reviewed, text in this section is a placeholder.

22. Bibliography Missing

23. Review Question 1 Does the chapter meet the requirements of the TDR mission statement? – In general yes, but – The level of detail in the descriptions of the different sections varies.

24. Review Question 2 Does the chapter adequatly cover the entire area of the topic? – Yes, as the chapter itself defines its coverage The definition in 5.1.1 is vague – Some parts are lacking in detail

25. Review Question 3 Is the content relevant to supporting the decision to proceed to construction? – Yes

26. Review Question 4 Is the content in the chapter properly balanced in length and in depth of detail? – No, some parts are described very briefly, some in greater detail.

27. Review Question 5 Does the chapter adequatly adress interfaces to other related systems described in other chapters? – The interface between MPS/PPS and the target safety system TSS is not well defined. – The interface between CS and Neutron scattering instruments is not consistent in the TDR.

28. Review Question 6 Are there duplications or inconsistencies within the chapter, and/or between related chapters? – Yes, with regard to definitions of scope of MPS, PPS and TPS. – The interfaces to the neutron scattering instruments.

29. Review Question 7 Does the chapter adequatly adress all phases of the ESS life cycle? – No, the different phases of the project are not discussed. Especially the decomissioning is not covered (e.g. BLED).

30. Review Question 8 Are risks and potential risks properly adressed and handled? – No, they are not adressed.

31. Review Question 9 Are there some especially positive features that should be promoted and strengthened for the construction phase, and which would improve the TDR if emphasized more? – TBD

32. Review Question 10 Are there andy critical remaining issues that you would like to adress? – Define what ”Safety” stands for in the TDR for ESS, and make that explicit. It now varies between machine, nuclear, personell, environment etc. Add qualifiers when using the term, as in ”radiation safety”. – No discussion of a site wide user permission system,or if each subsystem (BLED, HMI i control room, network access etc.) will have its own.

33. Recommendations Restructure chapter following figure 5.1 – Introduction – Control system Core – Control Box – Development Environment – HMI – BLED – (Interfaces) – MPS/PPS/(TSS)

34. Re: Safety Systems The safety systems of ESS are an important aspect, that will be scrutinized by external actors. The systems MPS, PPS, TSS are not handled in one place, but spread out through the document. Collect them in one place. Is overall physical/IT safety handled anywhere in the TDR? (Burglary, sabotage, espionage etc.)

35. Safety systems Chapter 3, Target – TSS, PPS Chapter 5, Controls systems, – MPS, PPS Chapter 11, Safety – Discusses safety, defines MPS – Lists safety systems including TSS, PPS