Download presentation
Presentation is loading. Please wait.
Published byJames Harvey Modified over 9 years ago
1
SEPO Training - Code Review & Design Review by Amanda
2
Confidential and proprietary Copyright 2011 / TELENAV GPS Navigator Always Find Your Way! / Independent Code Review Design Review by System Agenda
3
Confidential and proprietary Copyright 2011 / TELENAV GPS Navigator Always Find Your Way! / Process of Independent Code Review Assign Reviewer Owner: PJM Create Task on JIRA Owner: Reviewer Assign to DEV Lead Sign Reviewer’s Name on Release Note Owner: DEV Lead Code Ready Owner: DEV Lead Studio – Code Freeze Others – 1 st Submission Cross Component, Cross Team, Cross Group; Senior Engineer \\fs1\Program Office\Quality\Reviewers for Independent Code Review Accept and Review w/o Introduction Owner: Reviewer Review Comments Only (Necessary comments in the corresponding place; Refer to Coding Standard) Code Review Meeting Owner: Reviewer & DEV Lead Accept the build by Checking Release Note Owner: QA Resolved the Task by DEV Lead 1.Meeting is recommended, but not mandatory. 2.Reviewer shares thoughts with developers.
4
Confidential and proprietary Copyright 2011 / TELENAV GPS Navigator Always Find Your Way! / For PJM Assign Reviewer Owner: PJM Create Task on JIRA Owner: Reviewer Assign to DEV Lead Sign Reviewer’s Name on Release Note Owner: DEV Lead Code Ready Owner: DEV Lead Studio – Code Freeze Others – 1 st Submission Cross Component, Cross Team, Cross Group; Senior Engineer \\fs1\Program Office\Quality\Reviewers for Independent Code Review Accept and Review w/o Introduction Owner: Reviewer Review Comments Only (Necessary comments in the corresponding place; Refer to Coding Standard) Code Review Meeting Owner: Reviewer & DEV Lead Accept the build by Checking Release Note Owner: QA Resolved the Task by DEV Lead 1.Meeting is recommended, but not mandatory. 2.Reviewer shares thoughts with developers.
5
Confidential and proprietary Copyright 2011 / TELENAV GPS Navigator Always Find Your Way! / For DEV Lead Assign Reviewer Owner: PJM Create Task on JIRA Owner: Reviewer Assign to DEV Lead Sign Reviewer’s Name on Release Note Owner: DEV Lead Code Ready Owner: DEV Lead Studio – Code Freeze Others – 1 st Submission Cross Component, Cross Team, Cross Group; Senior Engineer \\fs1\Program Office\Quality\Reviewers for Independent Code Review Accept and Review w/o Introduction Owner: Reviewer Review Comments Only (Necessary comments in the corresponding place; Refer to Coding Standard) Code Review Meeting Owner: Reviewer & DEV Lead Accept the build by Checking Release Note Owner: QA Resolved the Task by DEV Lead 1.Meeting is recommended, but not mandatory. 2.Reviewer shares thoughts with developers. 3.Reviewer calls it.
6
Confidential and proprietary Copyright 2011 / TELENAV GPS Navigator Always Find Your Way! / For Reviewer Assign Reviewer Owner: PJM Create Task on JIRA Owner: Reviewer Assign to DEV Lead Sign Reviewer’s Name on Release Note Owner: DEV Lead Code Ready Owner: DEV Lead Studio – Code Freeze Others – 1 st Submission Cross Component, Cross Team, Cross Group; Senior Engineer \\fs1\Program Office\Quality\Reviewers for Independent Code Review Accept and Review w/o Introduction Owner: Reviewer Review Comments Only (Necessary comments in the corresponding place; Refer to Coding Standard) Code Review Meeting Owner: Reviewer & DEV Lead Accept the build by Checking Release Note Owner: QA Resolved the Task by DEV Lead 1.Meeting is recommended, but not mandatory. 2.Reviewer shares thoughts with developers.
7
Confidential and proprietary Copyright 2011 / TELENAV GPS Navigator Always Find Your Way! / For QA Assign Reviewer Owner: PJM Create Task on JIRA Owner: Reviewer Assign to DEV Lead Sign Reviewer’s Name on Release Note Owner: DEV Lead Code Ready Owner: DEV Lead Studio – Code Freeze Others – 1 st Submission Cross Component, Cross Team, Cross Group; Senior Engineer \\fs1\Program Office\Quality\Reviewers for Independent Code Review Accept and Review w/o Introduction Owner: Reviewer Review Comments Only (Necessary comments in the corresponding place; Refer to Coding Standard) Code Review Meeting Owner: Reviewer & DEV Lead Accept the build by Checking Release Note Owner: QA Resolved the Task by DEV Lead 1.Meeting is recommended, but not mandatory. 2.Reviewer shares thoughts with developers.
8
Confidential and proprietary Copyright 2011 / TELENAV GPS Navigator Always Find Your Way! / Design Review by System Ask for Review Mail to Rong Xing Owner: PJM Introduction and Q&A Meeting Owner: PJM / DEV / System / QA FSD/Design Doc Ready Owner: DEV Rong Xing will schedule the meeting. Reviewed Content: 1.Architecture Review 2.Finalize Key Function Point Studio – Review before Coding Others – At least ONCE in 3 months For Studio Project, like 7.1, 7.2, Main Components are enough. Assign 2 Reviewers for each Component Owner: Rong Xing Slides Preparation Owner: DEV Sign Reviewers’ Name and Review Date on Release Note Owner: DEV Lead Accept the build by Checking Review Date is within 3 months Owner: QA (from Apr 1 st ) Create Task on JIRA Owner: System Assign to DEV Lead Resolved the Task by DEV Lead
9
Confidential and proprietary Copyright 2011 / TELENAV GPS Navigator Always Find Your Way! / For PJM Ask for Review Mail to Rong Xing Owner: PJM Introduction and Q&A Meeting Owner: PJM / DEV / System / QA FSD/Design Doc Ready Owner: DEV Rong Xing will schedule the meeting. Reviewed Content: 1.Architecture Review 2.Finalize Key Function Point Studio – Review before Coding Others – At least ONCE in 3 months For Studio Project, like 7.1, 7.2, Main Components are enough. Assign 2 Reviewers for each Component Owner: Rong Xing Slides Preparation Owner: DEV Sign Reviewers’ Name and Review Date on Release Note Owner: DEV Lead Accept the build by Checking Review Date is within 3 months Owner: QA (from Apr 1 st ) Create Task on JIRA Owner: System Assign to DEV Lead Resolved the Task by DEV Lead
10
Confidential and proprietary Copyright 2011 / TELENAV GPS Navigator Always Find Your Way! / For DEV Ask for Review Mail to Rong Xing Owner: PJM Introduction and Q&A Meeting Owner: PJM / DEV / System / QA FSD/Design Doc Ready Owner: DEV Rong Xing will schedule the meeting. Reviewed Content: 1.Architecture Review 2.Finalize Key Function Point Studio – Review before Coding Others – At least ONCE in 3 months For Studio Project, like 7.1, 7.2, Main Components are enough. Assign 2 Reviewers for each Component Owner: Rong Xing Slides Preparation Owner: DEV Sign Reviewers’ Name and Review Date on Release Note Owner: DEV Lead Accept the build by Checking Review Date is within 3 months Owner: QA (from Apr 1 st ) Create Task on JIRA Owner: System Assign to DEV Lead Resolved the Task by DEV Lead
11
Confidential and proprietary Copyright 2011 / TELENAV GPS Navigator Always Find Your Way! / For System Ask for Review Mail to Rong Xing Owner: PJM Introduction and Q&A Meeting Owner: PJM / DEV / System / QA FSD/Design Doc Ready Owner: DEV Rong Xing will schedule the meeting. Reviewed Content: 1.Architecture Review 2.Finalize Key Function Point Studio – Review before Coding Others – At least ONCE in 3 months For Studio Project, like 7.1, 7.2, Main Components are enough. Assign 2 Reviewers for each Component Owner: Rong Xing Slides Preparation Owner: DEV Sign Reviewers’ Name and Review Date on Release Note Owner: DEV Lead Accept the build by Checking Review Date is within 3 months Owner: QA (from Apr 1 st ) Create Task on JIRA Owner: System Assign to DEV Lead Resolved the Task by DEV Lead
12
Confidential and proprietary Copyright 2011 / TELENAV GPS Navigator Always Find Your Way! / For QA Ask for Review Mail to Rong Xing Owner: PJM Introduction and Q&A Meeting Owner: PJM / DEV / System / QA FSD/Design Doc Ready Owner: DEV Rong Xing will schedule the meeting. Reviewed Content: 1.Architecture Review 2.Finalize Key Function Point Studio – Review before Coding Others – At least ONCE in 3 months For Studio Project, like 7.1, 7.2, Main Components are enough. Assign 2 Reviewers for each Component Owner: Rong Xing Slides Preparation Owner: DEV Sign Reviewers’ Name and Review Date on Release Note Owner: DEV Lead Accept the build by Checking Review Date is within 3 months Owner: QA (from Apr 1 st ) Create Task on JIRA Owner: System Assign to DEV Lead Resolved the Task by DEV Lead
13
Confidential and proprietary Copyright 2011 / TELENAV GPS Navigator Always Find Your Way! / http://spaces.telenav.com:8080/display/progr amoffice/Independent+Code+Review http://spaces.telenav.com:8080/display/progr amoffice/Independent+Code+Review http://spaces.telenav.com:8080/display/progr amoffice/Design+Review+by+System http://spaces.telenav.com:8080/display/progr amoffice/Design+Review+by+System Official Wiki
14
Thanks!
Similar presentations
© 2025 SlidePlayer.com. Inc.
All rights reserved.